Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update node-version for workspace #6428

Merged
merged 2 commits into from
Jun 6, 2022

Conversation

Lanttcat
Copy link
Contributor

@Lanttcat Lanttcat commented Jun 6, 2022

Why

I use fnm as Node.js version manager, it will auto change node version by node-version file.
Current pnpm hope use node >=17.0.0. and when use Node v16.8.0, pnpm will alert WARN  Unsupported engine: wanted: {"node":">=17.0.0"} (current: {"node":"v16.0.0","pnpm":"7.1.9"})

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2022

@github-actions github-actions bot temporarily deployed to pull request June 6, 2022 03:19 Inactive
Jack-Works
Jack-Works previously approved these changes Jun 6, 2022
@Jack-Works Jack-Works merged commit 83a3120 into develop Jun 6, 2022
@Jack-Works Jack-Works deleted the chore/update-project-node-version branch June 6, 2022 03:23
@github-actions github-actions bot temporarily deployed to pull request June 6, 2022 03:28 Inactive
etouyang added a commit to etouyang/Maskbook that referenced this pull request Jun 7, 2022
* 'develop' of github.com:etouyang/Maskbook: (173 commits)
  feat: more debugger connection actions (DimensionDev#6438)
  fix: sign tx by wallet with mnemonic words (DimensionDev#6437)
  fix: sign arbitrary message (DimensionDev#6436)
  fix: bugfix for refactor (DimensionDev#6434)
  fix: lost overrides (DimensionDev#6435)
  feat: add useAccountName (DimensionDev#6429)
  fix: button logic under EVM chain (DimensionDev#6431)
  fix: gas price fallback (DimensionDev#6432)
  chore: update node-version for workspace (DimensionDev#6428)
  refactor: social address list (DimensionDev#6410)
  fix: bugfix for trader (DimensionDev#6424)
  fix: duplicated db fetch (DimensionDev#6426)
  docs(i18n): sync i18n files from Crowdin (DimensionDev#6425)
  fix: tsc need restart to handle new file or removed file in watch mode
  fix: lint errors
  feat: referral farms (DimensionDev#6128)
  fix: fixup maskbox for evm migrate (DimensionDev#6395)
  fix: pets artblocks plugin (DimensionDev#6393)
  docs: update compat table
  refactor: add RecentTransactionComputed (DimensionDev#6420)
  ...

# Conflicts:
#	packages/dashboard/src/initialization/isolated_bridge.ts
#	packages/mask/src/extension/dashboard/index.tsx
#	packages/mask/src/plugins/Pets/SNSAdaptor/PetSetDialog.tsx
#	packages/mask/src/plugins/Pets/SNSAdaptor/PreviewBox.tsx
#	packages/mask/src/plugins/Pets/Services/rss3.ts
#	packages/mask/src/plugins/Pets/hooks/useNfts.ts
#	packages/shared/src/index.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants